On Wed, Mar 15, 2017 at 3:50 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Here is a reroll of what I did in > > http://public-inbox.org/git/xmqqd1die00j.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxx/ > > Junio C Hamano (2): > name-rev: refactor logic to see if a new candidate is a better name > name-rev: favor describing with tags and use committer date to tiebreak > > builtin/name-rev.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++++------ > t/t4202-log.sh | 2 +- > 2 files changed, 57 insertions(+), 8 deletions(-) > > -- > 2.12.0-306-g4a9b9b32d4 > This looks like an improvement to me. It may be that someone comes up with a better definition for is_better_name() but it's definitely much easier to do so now as it's easier to understand what the logic is when it's separated out. Thanks, Jake