Jeff King <peff@xxxxxxxx> writes: >> > > Yes, exactly. It would have been less confusing if I picked something >> > > that passed nongit_ok. Like hash-object: >> >> ... or like testing the early config directly? > > I was trying to demonstrate that the problem existed already without > your patch series. Yup, they are not new breakages introduced by Dscho's change. >> From: Johannes Schindelin <johannes.schindelin@xxxxxx> >> Subject: [PATCH] t1309: document cases where we would want early config not to >> die() >> >> Jeff King came up with a couple examples that demonstrate how the new >> read_early_config() that looks harder for the current .git/ directory >> could die() in an undesirable way. >> >> Let's add those cases to the test script, to document what we would like >> to happen when early config encounters problems. > > Yep, these all look fine. OK. Thanks, both.