This problem was identified as the root cause for what seemed to be a path conversion problem in the MSYS2 runtime at first glance. Original bug report: http://public-inbox.org/git/CAFKRc7y_kpCGNORENUZ2qw_4qBwjjyaaDFxAEQa52fTryj+w7A@xxxxxxxxxxxxxx/ We may want to consider fast-tracking this into v2.12.1, and to that end, I would appreciate code reviews that focus on the correctness of this patch and that try to consider undesired side effects. Johannes Schindelin (2): Demonstrate NULL pointer access with invalid GIT_WORK_TREE Fix callsites of real_pathdup() that wanted it to die on error abspath.c | 4 ++-- builtin/init-db.c | 6 +++--- cache.h | 2 +- dir.c | 4 ++-- environment.c | 2 +- setup.c | 4 ++-- submodule.c | 10 +++++----- t/t1501-work-tree.sh | 8 ++++++++ worktree.c | 2 +- 9 files changed, 25 insertions(+), 17 deletions(-) base-commit: e0688e9b28f2c5ff711460ee8b62077be5df2360 Published-As: https://github.com/dscho/git/releases/tag/real_pathdup-callers-v1 Fetch-It-Via: git fetch https://github.com/dscho/git real_pathdup-callers-v1 -- 2.12.0.windows.1.7.g94dafc3b124