On Wed, Mar 1, 2017 at 11:07 AM, Jeff King <peff@xxxxxxxx> wrote:
>
> So obviously the smaller object size is nice, and the diffstat is
> certainly satisfying. My only qualm would be whether this conflicts with
> the optimizations that Dan is working on (probably not conceptually, but
> textually).
Yeah. But I'll happily just re-apply the patch on any new version that
Dan posts. The patch is obviously trivial, even if size-wise it's a
fair number of lines.
So I wouldn't suggest using the patched version as some kind of
starting point. It's much easier to just take a new version of
upstream and repeat the diet patch on it.
.. and obviously later versions of the upstream sha1dc code may not
even need this at all since Dan and Marc are now aware of the issue.
Linus