On Wed, Mar 1, 2017 at 11:32 AM, Jeff King <peff@xxxxxxxx> wrote: > I would think that future callers would just need to provide a dummy > pp->rev. I guess that logic could be pushed down into > fmt_output_email_subject(), so that it skips looking at > opt->subject_prefix, etc, when "opt" is NULL, and just hits the > "Subject:" case arm. The "flexibility" I was wondering about is that the current .subject can point at any caller-supplied string, not "Subject:".