On 02/27, Junio C Hamano wrote: > Thomas Gummerer <t.gummerer@xxxxxxxxx> writes: > > > + test -n "$untracked" || git ls-files --error-unmatch -- "$@" >/dev/null || exit 1 > > This silent "exit 1" made me scratch my head, but --error-unmatch > would have already given an error message, like > > error: pathspec 'no such' did not match any file(s) known to git. > Did you forget to 'git add'? > > so that would be OK. Yeah exactly, the plan was to let --error-unmatch print the error message, as it's better at giving a good error message than we could easily do here I think. Maybe this deserves a comment so others won't have the same doubts about this line?