Junio C Hamano <gitster@xxxxxxxxx> writes: > Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes: > >> Johan Hovold <johan@xxxxxxxxxx> writes: >> >>> --- a/git-send-email.perl >>> +++ b/git-send-email.perl >>> @@ -1563,7 +1563,7 @@ foreach my $t (@files) { >>> # Now parse the message body >>> while(<$fh>) { >>> $message .= $_; >>> - if (/^(Signed-off-by|Cc): (.*)$/i) { >>> + if (/^(Signed-off-by|Cc): ([^>]*>?)/i) { >> >> I think this is acceptable, but this doesn't work with trailers like >> >> Cc: "Some > Body" <Some.Body@xxxxxxxxxxx> >> >> A proper management of this kind of weird address should be doable by >> reusing the regexp parsing "..." in parse_mailbox: >> >> my $re_quote = qr/"(?:[^\"\\]|\\.)*"/; >> >> So the final regex would look like >> >> if (/^(Signed-off-by|Cc): (([^>]*|"(?:[^\"\\]|\\.)*")>?)/i) { >> >> I don't think that should block the patch inclusion, but it may be worth >> considering. >> >> Anyway, thanks for the patch! > > Somehow this fell off the radar. So your reviewed-by: and then > we'll cook this in 'next' for a while? OK. -- Matthieu Moy http://www-verimag.imag.fr/~moy/