On Wed, Feb 22, 2017 at 03:42:25PM -0800, Junio C Hamano wrote: > "brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes: > > > We were lacking a test that covered the multi-parent case for commits. > > Add a basic test to ensure we do not regress this behavior in the > > future. > > > > Signed-off-by: brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx> > > --- > > t/t4013-diff-various.sh | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > It's a little bit ugly to me that this test hard-codes so many values, > > and I'm concerned that it may be unnecessarily brittle. However, I > > don't have a good idea of how to perform the kind of comprehensive test > > we need otherwise. > > Hmph, perhaps the expectation can be created out of the output from > 'git diff-tree master^ master' or something? Okay. I'll try that in a reroll. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204
Attachment:
signature.asc
Description: PGP signature