On 21 February 2017 at 02:00, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Siddharth Kannan <kannan.siddharth12@xxxxxxxxx> writes:
> > So, is it okay to stop with just supporting "-" and not support things
> > like "-@{yesterday}"?
>
> If the approach to turn "-" into "@{-1}" at that spot you did will
> cause "-@{yesterday}" to barf, then I'd say so be it for now ;-).
> We can later spread the understanding of "-" to functions deeper in
> the callchain and add support for that, no?
Yes, this can be done later. I will send these patches again, with
only the changes that are discussed here.
I will keep the tests for "-@{yesterday}" as failing tests, if that
would help in finding this again and fixing it later.
Thanks for your review, Junio!
--
Best Regards,
- Siddharth Kannan.