Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> writes: > That source showing should never have been in "show_decorations()" in > the first place. It just happened to be a convenient place for it. > > So this attached patch is just my original patch updated to split up > "show_source()" from "show_decorations()", and show it where it used > to be. The updated organization smells a lot better to me ;-) Most of the time it is convenient to have "show source" at the beginning of a single helper that is to show both, but oneline format is so special that it makes it inconvenient to have them at the same place. I can lose the patch to 4202 (update the expectation for --source) I added to the previous one, but the patch to 4207 (update the expectation for --decorate) needs to be kept with this round. Will replace; thanks.