On 02/14/2017 03:31 AM, brian m. carlson wrote: > This is another series in the continuing conversion to struct object_id. > > This series converts more of the builtin directory and some of the refs > code to use struct object_id. Additionally, it implements an > nth_packed_object_oid function which provides a struct object_id version > of the nth_packed_object function, and a parse_oid_hex function that > makes parsing easier. > > The patch to use parse_oid_hex in the refs code has been split out into > its own patch, just because I'm wary of that code and potentially > breaking things, and I want it to be easy to revert in case things go > wrong. I have no reason to believe it is anything other than fully > functional, however. > > Changes from v1: > * Implement parse_oid_hex and use it. > * Make nth_packed_object_oid take a variable into which to store the > object ID. This avoids concerns about unsafe casts. > * Rebase on master. Thanks as always for working on this! I skimmed over the patches (looking more carefully at the refs-related ones) and left a few minor comments but didn't find anything serious. I'm curious; what fraction of the overall convert-to-object_id campaign do you estimate is done so far? Are you getting close to the promised land yet? Michael