On Mon, Feb 13, 2017 at 9:45 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > SZEDER Gábor <szeder.dev@xxxxxxxxx> writes: > >> Recent commit 1cd23e9e0 (completion: don't use __gitdir() for git >> commands, 2017-02-03) rewrapped a couple of long lines, and while >> doing so it inadvertently removed a '\' from the end of a line, thus >> breaking completion for 'git config remote.name.push <TAB>'. >> >> Signed-off-by: SZEDER Gábor <szeder.dev@xxxxxxxxx> >> --- >> >> I wanted this to be a fixup!, but then noticed that this series is >> already in next, hence the proper commit message. > > We get "--format=... : command not found"? Yeah, that's the one. > Thanks for a set of sharp eyes. Heh. Sharp?! It took over five minutes to notice after I first got that error... Furthermore, that '\' was already missing in v1, almost a year ago :) >> I see the last What's cooking marks this series as "will merge to >> master". That doesn't mean that it will be in v2.12, does it? > > I actually was hoping that these can go in. Others that can (or > should) wait are marked as "Will cook in 'next'". > > If you feel uncomfortable and want these to cook longer, please tell > me so. Well, it was mainly my surprise that a 20+ patch series arriving so late that it gets queued on top of -rc0 would still make it into the release. However, I have been using this series with only minor modifications for the better part of a year now, so it's unlikely that there will be any big issues with it. Maybe something small, like this missing '\', but we will deal with it when it arises. Gábor