On Tue, Feb 14, 2017 at 3:58 AM, Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> wrote: >> -void files_path(struct files_ref_store *refs, struct strbuf *sb, >> - const char *fmt, ...) __attribute__((format (printf, 3, 4))); > > You only added this in the last commit, so maybe mark it static in > the previous patch! Also, just in case you were wondering, the 'Why?' > of the previous email was, "Why do you need this forward declaration?" > (hint: you don't ;-) Yeah, my compiler considers unused static functions an error. But I guess I should adjust those million compiler flags instead of doing it like this. I'll need to check if it's an error with DEVELOPER_CFLAGS because people may bisect with that. -- Duy