This makes sure that we actually use the pathspecs after "--" correctly (as opposed to just seeing if grep errored out). Signed-off-by: Jeff King <peff@xxxxxxxx> --- This could be squashed into the previous patch. I didn't end up using the "nongit" helper, because we actually have to do some other setup inside the subshell (this is the reason the earlier tests in this script don't use the helper, either). t/t7810-grep.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/t/t7810-grep.sh b/t/t7810-grep.sh index 29202f0e7..2c1f7373e 100755 --- a/t/t7810-grep.sh +++ b/t/t7810-grep.sh @@ -990,7 +990,10 @@ test_expect_success 'grep --no-index pattern -- path' ' export GIT_CEILING_DIRECTORIES && cd non/git && echo hello >hello && - git grep --no-index o -- . + echo goodbye >goodbye && + echo hello:hello >expect && + git grep --no-index o -- hello >actual && + test_cmp expect actual ) ' -- 2.12.0.rc1.471.ga79ec8999