Re: [PATCH v3 0/4] git gui: allow for a long recentrepo list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ping

Any comments anyone?
(https://public-inbox.org/git/20170122195301.1784-1-philipoakley@xxxxxxx/)

I understand that the Git-for-Windows team is planning to include this in their next release, so additional eyes are welcomed.

Philip

From: "Philip Oakley" <philipoakley@xxxxxxx> date: Sunday, January 22, 2017 7:52 PM
Way back in December 2015 I made a couple of attempts to patch up
the git-gui's recentrepo list in the face of duplicate entries in
the .gitconfig

The series end at http://public-inbox.org/git/9731888BD4C348F5BFC82FA96D978034@PhilipOakley/

A similar problem was reported recently on the Git for Windows list
https://github.com/git-for-windows/git/issues/1014 were a full
recentrepo list also stopped the gui working.

This series applies to Pat Thoyt's upstream Github repo as a merge
ready Pull Request https://github.com/patthoyts/git-gui/pull/10.
Hence if applied here it should be into the sub-tree git/git-gui.

I believe I've covered the points raised by Junio in the last review
and allowed for cases where the recentrepo list is now longer than the
maximum (which can be configured, both up and down).

I've cc'd just the cover letter to those involved previously, rather
than the series to avoid spamming.

There are various other low hanging fruit that the eager could look at
which are detailed at the end of the GfW/issues/104 referenced above.

Philip Oakley (4):
 git-gui: remove duplicate entries from .gitconfig's gui.recentrepo
 git gui: cope with duplicates in _get_recentrepo
 git gui: de-dup selected repo from recentrepo history
 git gui: allow for a long recentrepo list

lib/choose_repository.tcl | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)

--
2.9.0.windows.1.323.g0305acf
---
cc: Junio C Hamano <gitster@xxxxxxxxx>
cc: Pat Thoyts <patthoyts@xxxxxxxxxxxxxxxxxxxxx>,
cc: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>,
cc: Alexey Astakhov <asstv7@xxxxxxxxx>
cc: Johannes Schindelin <johannes.schindelin@xxxxxx>






[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]