The real_pathdup() function will have removed extra slashes for us already (on top of the normalize_path() done when we created the alternate_object_database struct in the first place). Incidentally, this also fixes the case where the path is just "/", which would read off the start of the array. That doesn't seem possible to trigger in practice, though, as link_alt_odb_entry() blindly eats trailing slashes, including a bare "/". Signed-off-by: Jeff King <peff@xxxxxxxx> --- transport.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/transport.c b/transport.c index 9ce0ee96b..6fba9e95b 100644 --- a/transport.c +++ b/transport.c @@ -1226,8 +1226,6 @@ static int refs_from_alternate_cb(struct alternate_object_database *e, return 0; len = strlen(other); - while (other[len-1] == '/') - other[--len] = '\0'; if (len < 8 || memcmp(other + len - 8, "/objects", 8)) goto out; /* Is this a git repository with refs? */ -- 2.12.0.rc0.371.ga6cf8653b