Hi Junio, On Tue, 7 Feb 2017, Junio C Hamano wrote: > Junio C Hamano <gitster@xxxxxxxxx> writes: > > > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > >>> > Likewise, this would become > >>> > > >>> > GIT_CEILING_DIRECTORIES="$PWD/not" \ > >>> > test_expect_code 129 git -C not/repo difftool -h >output && > >>> > grep ^usage: output > >>> > >>> I agree with the intent, but the execution here is "Not quite". > >>> test_expect_code being a shell function, it does not take the > >>> "one-shot environment assignment for this single invocation," like > >>> external commands do. > >> > >> So now that we know what is wrong, can you please enlighten me about > >> what is right? > > > > David's original is just fine, isn't it? > > I've also seen people use "env VAR=VAL git command" as the command to be > tested in t/ scripts. You can run that under test_expect_code, > methinks. That is exactly what David ended up sending out as follow-up patches. I did not mean to be critical, I just found it to be more helpful to accompany "that does not work" comments with "but this does" in the past. Ciao, Johannes