On Mon, Feb 6, 2017 at 7:31 PM, Jacob Keller <jacob.keller@xxxxxxxxx> wrote:
> On Fri, Feb 3, 2017 at 7:15 PM, Jacob Keller <jacob.keller@xxxxxxxxx> wrote:
>> I haven't had a chance to further investigate, but I tried this series
>> out (from your github) and it appears that this series (or the
>> previous series for __gitdir work) breaks "git log" ref completion.
>> I'll have further details when I am able to investigate a it more.
>>
>> Thanks,
>> Jake
>
> At first I had the same problem, but I verified by re-installing the
> completion script and the problem appears to have gone away. I suspect
> what happened is that the original time, I forgot to actually install
> the new version of git, and only installed the completion script, so
> when some of the commands were run with new options they (silently)
> failed and the result was missing completion values.
>
> Once I properly re-installed everything it appears to work as
> expected. I haven't found any other issues yet.
Thanks, that's good to hear.
Still, I'm a bit puzzled as to what exactly might have caused your
problem. Considering new options:
- the __gitdir()-related series added the 'git rev-parse
--absolute-git-dir' option, but only ever used it if you invoked
completion after 'git -C some/where'.
- The refs completion speedup didn't add any new options but started
to use two that it previously didn't:
- 'git for-each-ref --sort=<key>' option, but that's with us since
the earliest ever 'for-each-ref' version from more than a decade
ago...
- 'git for-each-ref' format modifier 'strip=2', which was
introduced in v2.7.1~15^2 (tag: do not show ambiguous tag names
as "tags/foo", 2016-01-25), only about a year ago. Were you
using a pre-2.7.1 version when seeing the problems?
Gábor