Matt McCutchen <matt@xxxxxxxxxxxxxxxxx> writes: > On Wed, 2017-02-01 at 12:56 -0800, Junio C Hamano wrote: > >> Let me make sure if I understood your changes correctly: >> ... >> So the condition to guard the call to update_file() also looks >> correct to me. > > All of the above matches my understanding. Would it have saved you > time if I had included some of this explanation in the patch "cover > letter"? The fact that I arrived at the same understanding by reading the change without peeking at such a cheat-sheet gives me more peace of mind ;-) Thanks.