cornelius.weig@xxxxxxxxxxx writes:
> From: Cornelius Weig <cornelius.weig@xxxxxxxxxxx>
>
> The commands git-branch and git-tag accept a `--create-reflog` argument.
For the purpose of contrasting the above with "--no-create-reflog",
I find it a bit too weak to just say "accept". How about
The commands git-branch and git-tag accept a `--create-reflog`
option, and creates reflog even in a repository where
core.logallrefupdates configuration is set not to.
or something? After all "--no-create-reflog" is accepted. It just
does not override the configured (or unconfigured) default.
> On the other hand, the negated form `--no-create-reflog` is accepted as
> a valid option but has no effect. This silent noop may puzzle users.
True, very true.
> To communicate that this behavior is intentional, add a short note in
> the manuals for git-branch and git-tag.
Hmph. The added "short note" merely states the fact; it does not
hint that it is intentional or it explains what reasoning is behind
that intention.
> Signed-off-by: Cornelius Weig <cornelius.weig@xxxxxxxxxxx>
> ---
>
> Notes:
> In a previous discussion (<xmqqbmunrwbf.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxx>) it
> was found that git-branch and git-tag accept a "--no-create-reflog" argument,
> but it has no effect, does not produce a warning, and is undocumented.
Reading what Peff said in the thread, I do not think we actively
wanted this behaviour; we agreed that it is merely acceptable.
So perhaps s/this behaviour is intentional/this is known/ to weaken
the log message? That way, when somebody else who really cares
comes later and finds this commit that adds explicit notes to these
manual pages via "git blame", s/he would not be dissuaded from
making things better. Such an update may make it warn when
core.logallrefupdates is not set to false (and continue to ignore
the command line option), or it may make the command line option
actually override the configured default.
With such an update to the log message, I think the patch looks
good.
Thanks.
> Documentation/git-branch.txt | 1 +
> Documentation/git-tag.txt | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/Documentation/git-branch.txt b/Documentation/git-branch.txt
> index 1fae4ee..fca3754 100644
> --- a/Documentation/git-branch.txt
> +++ b/Documentation/git-branch.txt
> @@ -91,6 +91,7 @@ OPTIONS
> based sha1 expressions such as "<branchname>@\{yesterday}".
> Note that in non-bare repositories, reflogs are usually
> enabled by default by the `core.logallrefupdates` config option.
> + The negated form `--no-create-reflog` is silently ignored.
>
> -f::
> --force::
> diff --git a/Documentation/git-tag.txt b/Documentation/git-tag.txt
> index 5b2288c..b0b933e 100644
> --- a/Documentation/git-tag.txt
> +++ b/Documentation/git-tag.txt
> @@ -152,6 +152,7 @@ This option is only applicable when listing tags without annotation lines.
> --create-reflog::
> Create a reflog for the tag. To globally enable reflogs for tags, see
> `core.logAllRefUpdates` in linkgit:git-config[1].
> + The negated form `--no-create-reflog` is silently ignored.
>
> <tagname>::
> The name of the tag to create, delete, or describe.