On Wed, 2 May 2007, Shawn O. Pearce wrote: > Dana How <danahow@xxxxxxxxx> wrote: > > > > Include a generalized fixup_header_footer() in this new file. > > Needed by git-repack --max-pack-size feature in a later patchset. > > Thanks. I'm applying this to my fastimport.git tree, but I changed > the name to fixup_pack_header_footer(). I'm also refactoring the > same code out of index-pack, to call your version. > > I'll ask Junio to pull your patch, and my index-pack cleanup soon. > As soon as I'm sure everything still passes the tests. ;-) BTW I think the common function should _not_ close the file descriptor it is being handed. It is more flexible to let the caller close the file, or possibly do whatever other operations like fchmod(). Nicolas - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html