On Fri, Jan 27, 2017 at 12:48 PM, Cornelius Weig <cornelius.weig@xxxxxxxxxxx> wrote: >> >> So maybe s/signed-off-by/helped-by/? >> > > This is getting real complex :-/ uh; sorry for that. I do not mind the patch as posted, just in case you reroll for another reason, this is worth thinking about. In fact, as said before I like that patch. > > As I said in the notes for the patch: > >>> As I don't know what is appropriate, I took the liberty to add everybody's >>> sign-off who was involved in the discussion in alphabetic order. > > With your explanation, I guess the most accurate sign-off chain would be: > > Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> (as you sent a patch) ...and here we could continue arguing. ;) Is the patch I sent note-worthy enough to be deriving work from? My gut reaction would be "no". > Helped-by: Philip Oakley <philipoakley@xxxxxxx> (no patch, but helpful) > Signed-off-by: Cornelius Weig <cornelius.weig@xxxxxxxxxxx> (this patch) > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> (once he decides it's good)