Junio C Hamano <gitster@xxxxxxxxx> writes: > + while (url_len && pat_len) { > + const char *url_next = end_of_token(url, '.', url_len); > + const char *pat_next = end_of_token(pat, '.', pat_len); > + ... > } > > + return 1; Embarrassing. The last one must be "have they both run out?" i.e. return (!url_len && !pat_len);