SZEDER Gábor <szeder.dev@xxxxxxxxx> writes: > On Wed, Dec 7, 2016 at 5:09 PM, SZEDER Gábor <szeder.dev@xxxxxxxxx> wrote: >> ref-filter's parse_ref_filter_atom() function parses an atom between >> the start and end pointers it gets as arguments. This is fine for two >> of its callers, which process '%(atom)' format specifiers and the end >> pointer comes directly from strchr() looking for the closing ')'. >> However, it's not quite so straightforward for its other two callers, >> which process sort specifiers given as plain nul-terminated strings. >> Especially not for ref_default_sorting(), which has the default >> hard-coded as a string literal, but can't use it directly, because a >> pointer to the end of that string literal is needed as well. >> The next patch will add yet another caller using a string literal. >> >> Add a helper function around parse_ref_filter_atom() to parse an atom >> up to the terminating nul, and call this helper in those two callers. >> >> Signed-off-by: SZEDER Gábor <szeder.dev@xxxxxxxxx> >> --- >> ref-filter.c | 8 ++------ >> ref-filter.h | 4 ++++ >> 2 files changed, 6 insertions(+), 6 deletions(-) > > Ping? > > It looks like that this little two piece cleanup series fell on the floor. I am still waiting for somebody else to comment on the changes, and the final reroll after such a review discussion to address your own comment in <CAM0VKjk1mnNzQX6LThq1t7keesBz_fjE9x2e0ywsBKSNKP9SCw@xxxxxxxxxxxxxx>