Ismail Dönmez <ismail@xxxxxxxxxxxxx> writes:
> Ok found out the reason. decode() tries to decode data that is already UTF-8
> and borks.
>
> This is from Encode.pm :
>
> sub decode_utf8($;$) {
> my ( $str, $check ) = @_;
> return $str if is_utf8($str); <--- Checks if the $str is already UTF-8
> if ($check) {
> return decode( "utf8", $str, $check ); <--- Else do what gitweb does
> [...]
>
> So my patch is indeed correct.
Ok, I think that makes it an improvement from the current code,
so I'd apply.
But at the same time I wonder why should the callers be feeding
an already decoded string to to_utf8(). It might be that some
callers needs fixing.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html