Re: [PATCH] show-ref: Allow --head to work with --verify

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2017-01-20 19:03, Junio C Hamano wrote:
and viewed in the wider context, I notice that quiet is not honored
in the added code.  I think that is easily fixable by replacing this
hunk with something like:

--quiet will still work correctly with the current patch, because show_ref already checks quiet. Granted, the original --verify code used show_one and not show_ref; however, I don't see a meaningful difference between calling show_ref and show_one for HEAD, other than a bit of overhead, so adding a new function may not be worthwhile. I will still add tests for this; however, in light of this, would you still like me to perform the change you requested?

--
Best regards,
 Vladimir



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]