v2: * Use obj->type instead of re-parsing name for delimiter (Followed Brandon's suggestion but named the variable 'delim' since that name is used in other places and 'del' is used for deletion.) * Add tests * Update Patch 1 commit description with a more relevant example * PATCH instead of RFC, now works with all documented git-rev-parse(1) syntax git-grep(1)'s output is not consistent with git-rev-parse(1) revision syntax. This means you cannot take "rev:path/to/file.c: foo();" output from git-grep(1) and expect "git show rev:path/to/file.c" to work. See the individual patches for examples of command-lines that produce invalid output. Stefan Hajnoczi (2): grep: only add delimiter if there isn't one already grep: use '/' delimiter for paths builtin/grep.c | 8 +++++++- t/t7810-grep.sh | 26 ++++++++++++++++++++++++++ 2 files changed, 33 insertions(+), 1 deletion(-) -- 2.9.3