On Fri, Jan 20, 2017 at 02:18:32PM +0000, Stefan Hajnoczi wrote:
> > Are there cases you know that aren't covered by your patches?
>
> From Patch 2/2:
>
> This patch does not cope with @{1979-02-26 18:30:00} syntax and treats
> it as a path because it contains colons.
>
> If we use obj->type instead of re-parsing the name then that problem is
> solved.
Ah, right. I somehow totally missed that, and blindly assumed your colon
search was only at the end. But of course that wouldn't work at all (it
would miss "v2.9.3:t").
So yes, definitely it should be checking the object type.
-Peff