On Thu, 2017-01-19 at 15:42 -0800, Jacob Keller wrote: > On Thu, Jan 19, 2017 at 1:20 PM, Jeff King <peff@xxxxxxxx> wrote: > > On Thu, Jan 19, 2017 at 09:43:45PM +0100, Wolfram Sang wrote: > > > > > > As to the implementation, I am wondering if we can make this somehow > > > > work well with the "trailers" code we already have, instead of > > > > inventing yet another parser of trailers. > > > > > > > > In its current shape, "interpret-trailers" focuses on "editing" an > > > > existing commit log message to tweak the trailer lines. That mode > > > > of operation would help amending and rebasing, and to do that it > > > > needs to parse the commit log message, identify trailer blocks, > > > > parse out each trailer lines, etc. > > > > > > > > There is no fundamental reason why its output must be an edited > > > > original commit log message---it should be usable as a filter that > > > > picks trailer lines of the selected trailer type, like "Tested-By", > > > > etc. > > > > > > I didn't know about trailers before. As I undestand it, I could use > > > "Tested-by" as the key, and the commit subject as the value. This list > > > then could be parsed and brought into proper output shape. It would > > > simplify the subject parsing, but most things my AWK script currently > > > does would still need to stay or to be reimplemented (extracting names > > > from tags, creating arrays of tags given by $name). Am I correct? > > > > > > All under the assumption that trailers work on a range of commits. I > > > have to admit that adding this to git is beyond my scope. > > > > This sounds a lot like the shortlog-trailers work I did about a year > > ago: > > > > http://public-inbox.org/git/20151229073832.GN8842@xxxxxxxxxxxxxxxxxxxxx/ > > > > http://public-inbox.org/git/20151229075013.GA9191@xxxxxxxxxxxxxxxxxxxxx/ > > > > Nobody seemed to really find it useful, so I didn't pursue it. > > > > Some of the preparatory patches in that series bit-rotted in the > > meantime, but you can play with a version based on v2.7.0 by fetching > > the "shortlog-trailers-historical" branch from > > https://github.com/peff/git.git. > > > > And then things like: > > > > git shortlog --ident=tested-by --format='...tested a patch by %an' > > > > work (and you can put whatever commit items you want into the --format, > > including just dumping the hash if you want to do more analysis). > > > > -Peff > > This sounds interesting to me! When I have some more time to take a > look at this i might see if I can revive it. Can the terminology please be standardized to what was once called bylines? https://patchwork.kernel.org/patch/9307703/