Normally color_parse_mem() is called from config parser which trims the leading spaces already. The new caller in the next patch won't. Let's be tidy and trim leading spaces too (we already trim trailing spaces before comma). Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> --- color.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/color.c b/color.c index a9eadd1..7bb4a96 100644 --- a/color.c +++ b/color.c @@ -207,10 +207,15 @@ int color_parse_mem(const char *value, int value_len, char *dst) struct color fg = { COLOR_UNSPECIFIED }; struct color bg = { COLOR_UNSPECIFIED }; + while (len > 0 && isspace(*ptr)) { + ptr++; + len--; + } + if (!len) return -1; - if (!strncasecmp(value, "reset", len)) { + if (!strncasecmp(ptr, "reset", len)) { xsnprintf(dst, end - dst, GIT_COLOR_RESET); return 0; } -- 2.8.2.524.g6ff3d78