On Wed, Jan 18, 2017 at 1:16 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Stefan Beller <sbeller@xxxxxxxxxx> writes: > >> Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> >> --- >> cache.h | 3 +++ >> read-cache.c | 1 - >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/cache.h b/cache.h >> index 270a0d0ea7..26632065a5 100644 >> --- a/cache.h >> +++ b/cache.h >> @@ -599,7 +599,10 @@ extern int index_name_pos(const struct index_state *, const char *name, int name >> #define ADD_CACHE_KEEP_CACHE_TREE 32 /* Do not invalidate cache-tree */ >> extern int add_index_entry(struct index_state *, struct cache_entry *ce, int option); >> extern void rename_index_entry_at(struct index_state *, int pos, const char *new_name); >> + >> +/* Remove entry, return 1 if there are more entries after pos. */ >> extern int remove_index_entry_at(struct index_state *, int pos); > > What is the reason why this now promise to return 1, as opposed to > the original that were allowed to return anything that is "true"? > Is it because you are adding other return values that mean different > things? > > If that is the case it may be fine (it depends on what these other > values mean and what use case it supports), but please do that in a > separate patch. > Actually my line of thinking was to improve the correctness by being more specific. In a reroll I move the comment verbatim.