GIT_PARSE_WITH(iconv)) sets NO_ICONV=YesPlease in https://github.com/git/git/blob/maint/configure.ac#L327 But the command GIT_CONF_SUBST([NO_ICONV]) in https://github.com/git/git/blob/maint/configure.ac#L618 is only executed when NO_ICONV is an empty variable https://github.com/git/git/blob/maint/configure.ac#L578 which has the effect that NO_ICONV=YesPlease is not written to config.mak.autogen which breaks compilation in systems without iconv. Signed-off-by: Bernd Kuhls <bernd.kuhls@xxxxxxxxxxx> --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 63e71a472..419469315 100644 --- a/configure.ac +++ b/configure.ac @@ -614,15 +614,15 @@ LIBS="$old_LIBS" GIT_UNSTASH_FLAGS($ICONVDIR) -GIT_CONF_SUBST([NEEDS_LIBICONV]) -GIT_CONF_SUBST([NO_ICONV]) - if test -n "$NO_ICONV"; then NEEDS_LIBICONV= fi fi +GIT_CONF_SUBST([NEEDS_LIBICONV]) +GIT_CONF_SUBST([NO_ICONV]) + # # Define NO_DEFLATE_BOUND if deflateBound is missing from zlib. -- 2.11.0