On Fri, Jan 13, 2017 at 10:48 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Jacob Keller <jacob.e.keller@xxxxxxxxx> writes: > >> From: Jacob Keller <jacob.keller@xxxxxxxxx> >> >> Teach git describe and git name-rev the ability to match multiple >> patterns inclusively. Additionally, teach these commands to also accept >> negative patterns to discard any refs which match. > > You made quick responses to reviews with "will change", so I am not > queuing this round to my tree; please don't mistake that as my > indifference or opposition to the topic. This sounds like a good > thing. Perfect. I will probably take a few days till I am back at a computer and can do this, but I will be submitting with the suggested changes soon. > > As to the semantics of mixing positives and negatives, I would > recommend this to follow how positive and negative pathspecs mix. > IIRC we chose to use the most simple and easy to explain option, > i.e. a thing must match at least one of the positives and must not > match any of the negatives to be considered a match. > > That is the current implementation, so I will stick with it. It's the simplest, and easiest to implement. Thanks, Jake