Stefan Beller <sbeller@xxxxxxxxxx> writes: > On Fri, Jan 13, 2017 at 11:55 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> Junio C Hamano <gitster@xxxxxxxxx> writes: >> >>> Stefan Beller <sbeller@xxxxxxxxxx> writes: >>> >>>> In modern Git we prefer "git -C <cmd" over "(cd <somewhere && git <cmd>)" >>>> as it doesn't need an extra shell. >>> >>> There is a matching '>' missing. The description is correct (I am >>> not sure if there actually is "preference", though), but I found the >>> title a bit misleading.... >> >> It turns out that there were two missing '>' ;-) It tentatively has >> become like this in my tree. > > Thanks for fixing up locally. I had resent as > "[PATCH] lib-submodule-update.sh: reduce use of subshell by using git -C <dir>" > but you can ignore that now. Yeah, apparently our mails crossed. Yours still have "git -C <cmd>" that should have been "git -C <dir> <cmd>", so I'll keep the locally munged one. Thanks.