Junio C Hamano <gitster@xxxxxxxxx> writes: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > ... >> >> I guess my only defence is that I tried to be a little lazy. > > I actually was alluding to going the other way around, spawning > "diff-tree -p" in the other codepath like this one does. Pre-emptively, because I expect it will take a while for me to clear the backlog to get to your reroll already on the mailing list, I do not mean to say that you must rewrite the other one to spawn to match this one. I meant that I wouldn't have minded if the series were done that way, as this kind of being "little lazy" would reduce the chance of regression by reducing the number of exchanged parts and it is not necessarily a bad thing.