Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: [...] >> +test_expect_success 'resolving @{push} fails with a detached HEAD' ' >> + git checkout HEAD^{} && > > I seem to recall that we prefer HEAD^0 over HEAD^{} and the existing > scripts seem to agree with me: > > $ git grep -c HEAD^0 junio/pu -- t/ > junio/pu:t/t1450-fsck.sh:1 > junio/pu:t/t1507-rev-parse-upstream.sh:2 > junio/pu:t/t2020-checkout-detach.sh:5 > junio/pu:t/t3200-branch.sh:1 > junio/pu:t/t3203-branch-output.sh:3 > junio/pu:t/t3400-rebase.sh:1 > junio/pu:t/t3404-rebase-interactive.sh:1 > junio/pu:t/t5407-post-rewrite-hook.sh:2 > junio/pu:t/t5505-remote.sh:1 > junio/pu:t/t5510-fetch.sh:1 > junio/pu:t/t5533-push-cas.sh:3 > junio/pu:t/t6035-merge-dir-to-symlink.sh:3 > junio/pu:t/t7201-co.sh:2 > junio/pu:t/t7402-submodule-rebase.sh:1 > junio/pu:t/t9105-git-svn-commit-diff.sh:1 > junio/pu:t/t9107-git-svn-migrate.sh:1 > > $ git grep -c HEAD^{} junio/pu -- t/ > junio/pu:t/t3200-branch.sh:3 > > Maybe use HEAD^0 just for consistency? Yes, thanks for pointing that out. -- Kyle