2017-01-06 20:43 GMT+01:00 Stefan Beller <sbeller@xxxxxxxxxx>: > On Fri, Jan 6, 2017 at 11:31 AM, Ralf Thielow <ralf.thielow@xxxxxxxxx> wrote: >> 2017-01-06 18:55 GMT+01:00 Stefan Beller <sbeller@xxxxxxxxxx>: >>> On Fri, Jan 6, 2017 at 9:25 AM, Jake Lambert <jake@xxxxxxxxxx> wrote: >>>> Hello, >>>> >>>> When executing "git branch <branch> --edit-description" on a branch with no description set, I get "fatal: could not unset 'branch.<branch>.description". It would seem that the unsetting piece should occur only after checking if it was set in the first place. >>> >>> That seems strange. Is it possible that your config is not writable? >>> (.git/config, ~/gitconfig, you'd need to find out where the <branch> >>> is configured already via git config --global/--system/--local --list) >>> >> >> Have you actually tried to reproduce this issue? I'm on current next >> and can reproduce the problem. > > eh, I was on $random_version that I currently have installed > (with messed up submodule code, but otherwise close to master). > > this gives hope that a bisect between master..next will give us a culprit? > Hm. I can confirm it appears on current master (e05806da9). >> >> I think removing things that don't exist should behave the same like >> removing things that do exist, with >> a success. > > I am not sure. Consider the tool "rm" > > $ rm no_exist > rm: cannot remove ‘no_exist’: No such file or directory > $ echo $? > 1 > > You have to use the --force. > > For this specific use case I agree we should then set the force flag > to let the the removal of the config option succeed no matter if it > existed before. > > Stefan Can you think of a case where this flag should be set to false? Ralf