Hey Luke, On Wed, Jan 4, 2017 at 2:41 PM, Luke Diamand <luke@xxxxxxxxxxx> wrote: > On 3 January 2017 at 19:57, Pranit Bauva <pranit.bauva@xxxxxxxxx> wrote: >> The exit code of the upstream in a pipe is ignored thus we should avoid >> using it. By writing out the output of the git command to a file, we can >> test the exit codes of both the commands. > > Do we also need to fix t9814-git-p4-rename.sh ? I don't think so. As Johannes[1] and Stefan[2] pointed out, we should avoid upstream pipes for git. p4 can be treated as an "external command" just like grep/sed. [1]: http://public-inbox.org/git/285ed013-5c59-0b98-7dc0-8f729587a313@xxxxxxxx/ [2]: http://public-inbox.org/git/CAGZ79kZRFLzD7wcAnFvke9vBxxTAgE7=Ud7F_O95EfkWqz=LJw@xxxxxxxxxxxxxx/