On 01/01/2017 04:28 AM, Junio C Hamano wrote:
> Michael Haggerty <mhagger@xxxxxxxxxxxx> writes:
>
>> + if (errno == ENOENT || errno == EISDIR) {
>> + /*
>> + * The logfile doesn't already exist,
>> + * but that is not an error; it only
>> + * means that we won't write log
>> + * entries to it.
>> + */
>> + } else {
>
> It may be valid C, but an
>
> {
> /*
> * an empty block without any statement,
> * not even a null statement.
> */
> }
>
> always makes me a bit nervous. Have a line with a semicolon without
> anything else (other than the indent) at the end and it will read
> nicer, at least to me.
That's a form of superstition that I haven't encountered before ;-) but
I'll change it.
Michael