On Thu, Dec 29, 2016 at 1:42 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Eric Wong <e@xxxxxxxxx> writes: > >> Eduardo Habkost <ehabkost@xxxxxxxxxx> wrote: >>> git-am has options to enable --message-id and --3way by default, >>> but no option to enable --signoff by default. Add a "am.signoff" >>> config option. >> >> I'm not sure this is a good idea. IANAL, but a sign-off >> has some sort of legal meaning for this project (DCO) >> and that would be better decided on a patch-by-patch basis >> rather than a blanket statement. > > IANAL either, but we have been striving to keep output of > > $ git grep '\.signoff' Documentation Try again with -i ;) and you'll find format.signOff > > empty to keep Sign-off meaningful. > > Adding more publicized ways to add SoB without thinking will make it > harder to argue against one who tells the court "that log message > ends with a SoB by person X but it is very plausible that it was > done by inertia without person X really intending to certify what > DCO says, and the SoB is meaningless". I think we should be symmetrical, am is the opposite of format-patch in the Git <-> email conversion. If I were to follow your arguments here, we should revert 1d1876e930 (Add configuration variable for sign-off to format-patch) On the other hand, I would argue that thinking and typing things is orthogonal (the more you type, doesn't imply that you think harder or even at all). -- However I think there is a use case for such an option (in the short term?) as e.g. you as the Git maintainer being employed has the legal rights to sign off on pretty much any patch in Git. For other projects this may be different. Which is why a per-repository configurable thing is useful to setup a default for your environment. IIUC long term we rather want to have easily configurable trailers for am/format-patch/commit, such that you could configure to remove any "ChangeId:" footers before sending out, or adding a "Tested-by" footer by a CI system or such? > >> I don't add my SoB to patches (either my own or received) until >> I'm comfortable with it; comfortable is orthogonal to legal, specifically on the receiving side. I can understand using format-patch to send out unsigned patches (e.g. for heavy WIP things, "please to not apply literally") >> and I'd rather err on the side of >> forgetting and being prodded to resubmit rather than putting >> an SoB on the wrong patch. >