Re: [PATCH v3 1/2] auto gc: don't write bitmaps for incremental repacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 23, 2016 at 08:08:54PM -0500, David Turner wrote:

> +	git gc --auto 2>err &&
> +	test_i18ngrep ! "^warning:" err &&
> +	ls .git/objects/pack/ | grep -v bitmap | sort >post_packs &&

I'm not sure why you omit the bitmap here. It shouldn't change, right?
In that case it should not be mentioned by comm, and not impact the
counts you check later (and in the off chance that a new .bitmap is
created, we'd want to know and fail the test, I would think).

> +	comm --output-delimiter , -1 -3 existing_packs post_packs >new &&
> +	comm --output-delimiter , -2 -3 existing_packs post_packs >del &&

I don't think --output-delimiter will be portable beyond GNU comm.

> +	test_line_count = 0 del && # No packs are deleted
> +	test_line_count = 2 new # There is one new pack and its .idx

This logic makes sense (and is much nicer than the previous round).

-Peff



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]