Re: [PATCH] mingw: add a regression test for pushing to UNC paths

[Johannes Sixt <j6t@xxxxxxxx>]

Am 23.12.2016 um 18:11 schrieb Johannes Schindelin:
> Let's make sure that it does not regress again, by introducing a test
> that uses so-called "administrative shares": disk volumes are
> automatically shared under certain circumstances, e.g.  the C: drive is
> shared as \\localhost\c$.

Clever!

> +test_expect_success setup '
> +	test_commit initial
> +'
> +
> +test_expect_success clone '
> +	git clone "file://$UNCPATH" clone
> +'
> +
> +test_expect_success push '
> +	(
> +		cd clone &&
> +		git checkout -b to-push &&
> +		test_commit to-push &&
> +		git push origin HEAD
> +	)
> +'
> +
> +test_done

Wouldn't at a minimum

test_expect_success 'check push result' '
	git rev-parse to-push
'

be a good idea to make sure that the pushed commit actually arrived?

-- Hannes