Hi Junio, On Thu, 22 Dec 2016, Junio C Hamano wrote: > Johannes Schindelin <johannes.schindelin@xxxxxx> writes: > > > - unsquashed 2/3 which was improperly snuck in before, > > As Windows specific changes, I didn't notice these two were independent. Yeah, sorry, I only realized today that I had snuck that one in when re-reviewing the changes. > > - fixed the confusing commit message by using Junio's suggested > > replacement > > Sorry, but I didn't mean to "suggest replacement". I was just > testing my understanding by attempt to rephrase the gist of it. I did like your phrasing, though. > There was one thing I still wasn't clear in my "summary of my > understanding". Is the "replacement originally done for compiling > with VC++" a solution that still peeks into MSVC runtime internals > but is usable with both old and more recent one? Or is it a more > kosher approach that does not play with the internals to make it > unlikely that it would have to change again in the future? Oh, it is kosher. There is no more messing with internals. > Your "use this opportunity to actually clean up" above suggests that > the answer is the latter, but if you took my "summary of my > understanding", it is likely that that fact is not captured in the > resulting log message. Right... I tried to make that clear by saying that this change replaces the hack. > The interdiff obviously looks good. Let's move this series forward. > I'll see if it can be merged down to 'maint', too, but it probably > would not matter that much. I will have to release a new Git for Windows version Real Soon Now [*1*], so I will have to take those patches kind of there (as Git for Windows will be based on upstream/maint for a while now). My thinking is that I will publish a prerelease either tonight or tomorrow, then go offline until next year, and then immediately publish Git for Windows v2.11.0(2) (or v2.11.1 if you publish a bugfix version in the meantime). Ciao, Dscho Footnote *1*: There is a new cURL version with some security fixes, although I do not think they are super-critical, then there is the fix for the double slashes in //server/share/directory, the fix for the empty credentials and I should probably also try to update the MSYS2 runtime to the newest version of Cygwin's runtime. Lots of stuff.