Re: [PATCH bw/realpath-wo-chdir] real_path: canonicalize directory separators in root parts

[Johannes Sixt <j6t@xxxxxxxx>]

Am 21.12.2016 um 23:33 schrieb Brandon Williams:
> On 12/21, Johannes Sixt wrote:
> > +/* copies root part from remaining to resolved, canonicalizing it on the way */
> > +static void get_root_part(struct strbuf *resolved, struct strbuf *remaining)
> > +{
> > +	int offset = offset_1st_component(remaining->buf);
> > +
> > +	strbuf_reset(resolved);
> > +	strbuf_add(resolved, remaining->buf, offset);
> > +#ifdef GIT_WINDOWS_NATIVE
> > +	convert_slashes(resolved->buf);
> > +#endif
>
> So then the only extra cononicalization that is happening here is
> converting '\\server\share' to '//server/share'? (or 'c:\' to 'c:/')

Correct. All other directory separators are canonicalized by the primary 
function, strbuf_realpath.

-- Hannes