On Mon, Dec 19, 2016 at 3:32 PM, Brandon Williams <bmwill@xxxxxxxxxx> wrote:
>> + strbuf_addstr(&err, "git ");
>> + for (i = 0; cmd->argv[i]; )
>
> Missing the increment of i here.
Doh :(
When writing the code I was undecided between using
an incremental loop "for (i = 0; cmd->argv[i]; i++)" and
a pointer arithmetic thing as "for(;;) {... cmd->argv++;",
and ended up with a broken middle ground.