Michael Haggerty writes ("Re: [PATCH 1/5] check-ref-format: Refactor out check_one_ref_format"): > On 11/04/2016 08:13 PM, Ian Jackson wrote: > > +static int check_one_ref_format(const char *refname) ... > This function needs to `return 0` if it gets to the end. Indeed it does. I'm kind of surprised my compiler didn't spot that. Thanks for the careful review! Regards, Ian. -- Ian Jackson <ijackson@xxxxxxxxxxxxxxxxxxxxxx> These opinions are my own. If I emailed you from an address @fyvzl.net or @evade.org.uk, that is a private address which bypasses my fierce spamfilter.