On Sat, Dec 17, 2016 at 7:13 PM, Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> wrote: > > > On 17/12/16 08:38, Karthik Nayak wrote: >> Hello, >> >>> >>> * kn/ref-filter-branch-list (2016-12-08) 20 commits >>> - branch: implement '--format' option >>> - branch: use ref-filter printing APIs >>> - branch, tag: use porcelain output >>> - ref-filter: allow porcelain to translate messages in the output >>> - ref-filter: add an 'rstrip=<N>' option to atoms which deal with refnames >>> - ref-filter: modify the 'lstrip=<N>' option to work with negative '<N>' >>> - ref-filter: rename the 'strip' option to 'lstrip' >>> - ref-filter: make remote_ref_atom_parser() use refname_atom_parser_internal() >>> - ref-filter: introduce refname_atom_parser() >>> - ref-filter: introduce refname_atom_parser_internal() >>> - ref-filter: make "%(symref)" atom work with the ':short' modifier >>> - ref-filter: add support for %(upstream:track,nobracket) >>> - ref-filter: make %(upstream:track) prints "[gone]" for invalid upstreams >>> - ref-filter: introduce format_ref_array_item() >>> - ref-filter: move get_head_description() from branch.c >>> - ref-filter: modify "%(objectname:short)" to take length >>> - ref-filter: implement %(if:equals=<string>) and %(if:notequals=<string>) >>> - ref-filter: include reference to 'used_atom' within 'atom_value' >>> - ref-filter: implement %(if), %(then), and %(else) atoms >>> - for-each-ref: do not segv with %(HEAD) on an unborn branch >>> >>> The code to list branches in "git branch" has been consolidated >>> with the more generic ref-filter API. >>> >>> What's the doneness of the topic? I recall discussing die vs empty >>> and also saw a "squash this in when you reroll", but I lost track. >>> >> >> I was waiting for more reviews, if any. >> For now we need to come to a conclusion on the die vs empty discussion >> (http://marc.info/?l=git&m=148112502029302&w=2) I'll start working on returning >> empty rather than die. >> >> Also Jeff suggested some changes, which I've incorporated into my local branch. >> (http://marc.info/?t=148112503600001&r=1&w=2). I'll reroll if no >> further changes are >> suggested soon :) > > Not forgetting to make 'quote_literal_for_format()' static. ;-) > Of Course, thanks for the reminder :) -- Regards, Karthik Nayak