On Fri, Dec 16, 2016 at 9:28 PM, Lars Schneider <larsxschneider@xxxxxxxxx> wrote: > > On 14 Dec 2016, at 12:24, Jeff King <peff@xxxxxxxx> wrote: > > On Wed, Dec 14, 2016 at 10:27:31PM +1300, Chris Packham wrote: > > Changes in v2: > > - only run over actual git source files. > > - omit any files in t/ > > > I actually wonder if FIND_SOURCE_FILES should be taking care of the "t/" > thing. I think "make tags" finds tags in t4051/appended1.c, which is > just silly. > > - introduce CPPCHECK_FLAGS which can be overridden in the make command > > line. This also uses a GNU make-ism to allow CPPCHECK_ADD to specify > > additional checks to be enabled. > > > The GNU-ism is fine; we already require GNU make to build. > > The patch itself is OK to me, I guess. The interesting part will be > whether people start actually _using_ cppcheck and squelching the false > positives. > > > @Chris: If this gets in then it would be great to run it as part of the > Travis-CI build: https://travis-ci.org/git/git/branches > Yeah I was thinking about this. Since as always with a new tool there are some doubts over it's usefulness. I could easily hook it up to a branch in my own fork of git and keep that branch rebased on top of pu. I'd need to keep an eye on it myself and report errors on the list. If that goes well, at some point someone will ask how I'm detecting these errors. Then I can point them at this patchset and if enough people want easy access to it then that may provide an incentive for this to be merged into git.git.