Jeff King <peff@xxxxxxxx> writes: > It obviously would need updating if we switch away from "-c", but I > think I am OK with the short "-c" (even if we add a more exotic grouping > option later, this can remain as a short synonym). Yeah, I think it probably is OK. As it is very clear that "group by author" is the default, there is no need to add the corresponding "-a/--author" option, either. The fact that "--no-committer" can countermand an earlier "--committer" on the command line is just how options work, so it probably does not deserve a separate mention, either. Thanks. > -- >8 -- > Subject: [PATCH] shortlog: test and document --committer option > > This puts the final touches on the feature added by > fbfda15fb8 (shortlog: group by committer information, > 2016-10-11). > > Signed-off-by: Jeff King <peff@xxxxxxxx> > --- > Documentation/git-shortlog.txt | 4 ++++ > t/t4201-shortlog.sh | 13 +++++++++++++ > 2 files changed, 17 insertions(+) > > diff --git a/Documentation/git-shortlog.txt b/Documentation/git-shortlog.txt > index 31af7f2736..ee6c5476c1 100644 > --- a/Documentation/git-shortlog.txt > +++ b/Documentation/git-shortlog.txt > @@ -47,6 +47,10 @@ OPTIONS > > Each pretty-printed commit will be rewrapped before it is shown. > > +-c:: > +--committer:: > + Collect and show committer identities instead of authors. > + > -w[<width>[,<indent1>[,<indent2>]]]:: > Linewrap the output by wrapping each line at `width`. The first > line of each entry is indented by `indent1` spaces, and the second > diff --git a/t/t4201-shortlog.sh b/t/t4201-shortlog.sh > index ae08b57712..6c7c637481 100755 > --- a/t/t4201-shortlog.sh > +++ b/t/t4201-shortlog.sh > @@ -190,4 +190,17 @@ test_expect_success 'shortlog with --output=<file>' ' > test_line_count = 3 shortlog > ' > > +test_expect_success 'shortlog --committer (internal)' ' > + cat >expect <<-\EOF && > + 3 C O Mitter > + EOF > + git shortlog -nsc HEAD >actual && > + test_cmp expect actual > +' > + > +test_expect_success 'shortlog --committer (external)' ' > + git log --format=full | git shortlog -nsc >actual && > + test_cmp expect actual > +' > + > test_done