On Thu, Dec 15, 2016 at 08:37:28PM -0500, Jeff King wrote: > But if this case really is just "if (from_stdin)" that's quite easy, > too. So here is that patch (with some associated refactoring and cleanups). This is conceptually independent of jk/no-looking-at-dotgit-outside-repo-final, though it should be fine to merge with that topic. The BUG will actually pass the new test, because it calls die, too. I wonder if we should die with a unique error code on BUGs, and catch them in test_must_fail similar to the way we catch signal death. [1/3]: t5000: extract nongit function to test-lib-functions.sh [2/3]: index-pack: complain when --stdin is used outside of a repo [3/3]: t: use nongit() function where applicable builtin/index-pack.c | 2 ++ t/t1308-config-set.sh | 10 ++-------- t/t5000-tar-tree.sh | 14 -------------- t/t5300-pack-object.sh | 15 +++++++++++++++ t/t9100-git-svn-basic.sh | 17 ++--------------- t/t9902-completion.sh | 7 +------ t/test-lib-functions.sh | 14 ++++++++++++++ 7 files changed, 36 insertions(+), 43 deletions(-) -Peff